[qpoasse_interface test] PR added check for equality constraints #18
Merged
mmmarinho merged 5 commits intodqrobotics:masterfrom Dec 8, 2023
Merged
[qpoasse_interface test] PR added check for equality constraints #18mmmarinho merged 5 commits intodqrobotics:masterfrom
mmmarinho merged 5 commits intodqrobotics:masterfrom
Conversation
Member
|
Hi @qlin960618, as mentioned in PR1, the cpp-interface-qpoases you are proposing is not running with the current example. I'll wait for your reply to review this PR. Please note that your commit messages are not following the DQ Robotics convention, which is summarized in CONTRIBUTING.md. Please update your messages in newer commits. Best regards, Juan |
juanjqo
reviewed
Nov 6, 2023
juanjqo
reviewed
Nov 6, 2023
juanjqo
reviewed
Nov 6, 2023
juanjqo
reviewed
Nov 6, 2023
juanjqo
reviewed
Nov 6, 2023
juanjqo
reviewed
Nov 6, 2023
juanjqo
suggested changes
Nov 6, 2023
Member
juanjqo
left a comment
There was a problem hiding this comment.
@qlin960618 Thank you for your PR. There are some minor modifications.
juanjqo
suggested changes
Dec 8, 2023
Member
|
@mmmarinho This PR is ready for your review. |
Member
|
@juanjqo Are all points of discussion resolved? Can I mark them as resolved if you're unable to do so? |
Member
|
@mmmarinho Yes, all points were resolved. I am not allowed to mark them as resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mmmarinho,
This PR added test for the DQ_QPOASESSolver equality constraints check that is in tandem with the PR #1 in that Repo.
Some modification were made to the original code limited to the structure, in addition to a new
test_equalitytest case.qlin
Best,