Skip to content

[qpoasse_interface test] PR added check for equality constraints #18

Merged
mmmarinho merged 5 commits intodqrobotics:masterfrom
qlin960618:master
Dec 8, 2023
Merged

[qpoasse_interface test] PR added check for equality constraints #18
mmmarinho merged 5 commits intodqrobotics:masterfrom
qlin960618:master

Conversation

@qlin960618
Copy link
Copy Markdown
Contributor

Hi @mmmarinho,

This PR added test for the DQ_QPOASESSolver equality constraints check that is in tandem with the PR #1 in that Repo.
Some modification were made to the original code limited to the structure, in addition to a new test_equality test case.

Screenshot 2023-10-30 at 7 46 38 PM

qlin
Best,

@juanjqo
Copy link
Copy Markdown
Member

juanjqo commented Nov 3, 2023

Hi @qlin960618, as mentioned in PR1, the cpp-interface-qpoases you are proposing is not running with the current example. I'll wait for your reply to review this PR.

Please note that your commit messages are not following the DQ Robotics convention, which is summarized in CONTRIBUTING.md. Please update your messages in newer commits.

Please indicate in your commit message, using brackets, the modified file. For instance, if you modified the class DQ_SerialManipulator, then you would do the following:

git commit -m "[DQ_SerialManipulator] your_message_explaining_the modification."

Best regards,

Juan

Comment thread cmake/qpoases_interface/qpoases_interface.cpp Outdated
Comment thread cmake/qpoases_interface/qpoases_interface.cpp
Comment thread cmake/qpoases_interface/qpoases_interface.cpp Outdated
Comment thread cmake/qpoases_interface/qpoases_interface.cpp Outdated
Comment thread cmake/qpoases_interface/qpoases_interface.cpp
Comment thread cmake/qpoases_interface/qpoases_interface.cpp Outdated
Copy link
Copy Markdown
Member

@juanjqo juanjqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qlin960618 Thank you for your PR. There are some minor modifications.

Comment thread cmake/qpoases_interface/qpoases_interface.cpp Outdated
@juanjqo
Copy link
Copy Markdown
Member

juanjqo commented Dec 8, 2023

@mmmarinho This PR is ready for your review.

@mmmarinho
Copy link
Copy Markdown
Member

@juanjqo Are all points of discussion resolved? Can I mark them as resolved if you're unable to do so?

@juanjqo
Copy link
Copy Markdown
Member

juanjqo commented Dec 8, 2023

@mmmarinho Yes, all points were resolved. I am not allowed to mark them as resolved.

Copy link
Copy Markdown
Member

@mmmarinho mmmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanjqo Seems fine. I'll proceed with the merge and let me know if something goes wrong.

@mmmarinho mmmarinho merged commit ec999c8 into dqrobotics:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants