Skip to content

Conversation

@juanjqo
Copy link
Member

@juanjqo juanjqo commented May 7, 2025

Main instructions

By submitting this pull request, you automatically agree that you have read and accepted the following conditions:

  • Anyone wanting to propose a new modification or introduce new functionality should reach out to the team first, as proposed modifications that do not comply with the library's development philosophy and style, do not follow the library's architecture, do not introduce a clear and general benefit to the library other than to the person who proposed the modification will likely be rejected with no further discussion.
  • Support for DQ Robotics is given voluntarily and it is not the developers' role to educate and/or convince anyone of their vision.
  • Any possible response and its timeliness will be based on the relevance, accuracy, and politeness of a request and the following discussion.
  • You are familiar with the development workflow.
  • Each pull request should contain only individual changes (several changes of the same type are allowed on the same pull request).
  • Refactoring or modifying internal implementation that is working is not allowed unless comprehensively discussed with and approved by @bvadorno and @mmmarinho.

Description of changes

This PR adds the abstract method pose_jacobian_derivative() in the DQ_Kinematics class. The subclasses implement the respective concrete methods, but an exception is thrown if the user tries to use them. In other words, the concrete methods are not yet available to the user (except for the DQ_SerialManipulator class, in which the pose_jacobian_derivative method is implemented since 4ada8bb). The concrete implementations for each subclass will be proposed in future PRs.

Current:

JacobianDerivative_pre

Proposal:
JacobianDerivative

Rationale

Kind regards,

Juancho

Copy link
Member

@bvadorno bvadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @juanjqo. Could you please fix the minor issues I've indicated?

Many thanks,
Bruno

@juanjqo
Copy link
Member Author

juanjqo commented May 14, 2025

Thanks, @juanjqo. Could you please fix the minor issues I've indicated?

Many thanks, Bruno

Hi @bvadorno,

I updated your email. =)

Kind regards,

Juancho

@bvadorno bvadorno merged commit d944b85 into dqrobotics:master May 14, 2025
1 of 2 checks passed
@juanjqo juanjqo deleted the pose_jacobian_derivative branch May 17, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants