Skip to content

Fix line_to_line_residual def in DQ_Kinematics_py.cpp#47

Merged
mmmarinho merged 1 commit into
dqrobotics:masterfrom
qlin960618:patch-1
Jun 8, 2023
Merged

Fix line_to_line_residual def in DQ_Kinematics_py.cpp#47
mmmarinho merged 1 commit into
dqrobotics:masterfrom
qlin960618:patch-1

Conversation

@qlin960618
Copy link
Copy Markdown
Contributor

@qlin960618 qlin960618 commented Jun 8, 2023

Request for bug fix in dqrobotics python for DQ_Kinematic reference to line_to_line_residual fucntion

Edit by @mmmarinho for clarity:

Bug & Cause

There is no line_to_line_residual accessible through the Python API. See #48

Fix

The two references to line_to_point_residual in L64, shown below, must be replaced by line_to_line_residual.

dqkinematics_py.def_static("line_to_point_residual", &DQ_Kinematics::line_to_point_residual, "Returns the robot line to line residual");

Copy link
Copy Markdown
Member

@mmmarinho mmmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qlin960618 Thanks.

The fix in the code seems pretty straightforward, but could you better describe the situation in the first comment?

We need these to have a decent description so that we can keep track of the changes we made.

@mmmarinho mmmarinho merged commit 51d6dbc into dqrobotics:master Jun 8, 2023
@qlin960618 qlin960618 deleted the patch-1 branch June 8, 2023 04:01
@mmmarinho mmmarinho changed the title fix line_to_line_residual incorrect def in DQ_Kinematics_py.cpp Fix line_to_line_residual def in DQ_Kinematics_py.cpp Jun 12, 2023
@mmmarinho mmmarinho self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants