Fix line_to_line_residual def in DQ_Kinematics_py.cpp#47
Merged
Conversation
mmmarinho
requested changes
Jun 8, 2023
Member
mmmarinho
left a comment
There was a problem hiding this comment.
@qlin960618 Thanks.
The fix in the code seems pretty straightforward, but could you better describe the situation in the first comment?
We need these to have a decent description so that we can keep track of the changes we made.
line_to_line_residual def in DQ_Kinematics_py.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request for bug fix in dqrobotics python for DQ_Kinematic reference to line_to_line_residual fucntionEdit by @mmmarinho for clarity:
Bug & Cause
There is no
line_to_line_residualaccessible through the Python API. See #48Fix
The two references to
line_to_point_residualin L64, shown below, must be replaced byline_to_line_residual.python/src/robot_modeling/DQ_Kinematics_py.cpp
Line 64 in 413595e