feat: add show_footer config option to hide footer#32
Open
FernandoCelmer wants to merge 3 commits intodevelopfrom
Open
feat: add show_footer config option to hide footer#32FernandoCelmer wants to merge 3 commits intodevelopfrom
FernandoCelmer wants to merge 3 commits intodevelopfrom
Conversation
- tests/test_show_footer.py: 6 tests covering default config value, footer visibility with show_footer=true/false, and template guard - pyproject.toml: add pytest, pytest-cov, pyyaml dev dependencies - .github/workflows/test.yml: CI on Python 3.10/3.11/3.12 Refs #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue: #28
mkdocs_dracula_theme/mkdocs_theme.yml: addedshow_footer: trueas a default config keymkdocs_dracula_theme/base.html: wrapped the footer include block with{% if config.theme.show_footer %}conditionalMotivation and Context
Users who want to hide the "Made with Dracula Theme for MkDocs" footer had no native way to do so. Setting
show_footer: falseinmkdocs.ymlnow suppresses it cleanly without requiring acustom_diroverride.Closes #28
Type of change
Checklist: