feat: add admonition styles with Dracula colors and Font Awesome icons#33
Open
FernandoCelmer wants to merge 4 commits intodevelopfrom
Open
feat: add admonition styles with Dracula colors and Font Awesome icons#33FernandoCelmer wants to merge 4 commits intodevelopfrom
FernandoCelmer wants to merge 4 commits intodevelopfrom
Conversation
FernandoCelmer
commented
Mar 25, 2026
Member
Author
FernandoCelmer
left a comment
FernandoCelmer
left a comment
There was a problem hiding this comment.
🔍 Code Review
Code issues found: 3
See inline comments below.
- revert version bump to 1.0.9-dev1 (let CI handle release) - minify admonition CSS in mkdocs.min.css - replace fa-fire with fa-lightbulb-o for tip/hint/important admonitions Refs #29
Add pytest suite covering admonition CSS rules introduced in this PR: - CSS coverage: all 26 admonition types present in source and minified files - Icon validation: correct Font Awesome 4.7 codepoints per type - Color validation: Dracula CSS variables used (no hardcoded hex) - Minified format: single-line, no comments, shorthand values Refs #29
FernandoCelmer
force-pushed
the
feature/29
branch
from
cf3e2f1 to
f0b29ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
template/assets/css/mkdocs.css: added admonition styles covering all MkDocs admonition typesmkdocs_dracula_theme/assets/css/mkdocs.min.css: added the same styles to the served stylesheetMotivation and Context
Admonition blocks (
!!! note,!!! warning, etc.) rendered without any visual styling in the theme. MkDocs emits the correct HTML structure but the theme had no.admonitionCSS rules at all.This adds styled admonitions using the Dracula color palette (CSS variables from
dracula-ui.min.css) and Font Awesome 4.7 icons — which are already loaded unconditionally inbase.html. Each admonition type gets a color-coded left border, a matching transparent background, and an icon in the title bar.Closes #29
Types of changes
Checklist