Skip to content

Update from experimental variables#28

Merged
dsifford merged 3 commits intodracula:masterfrom
Eric-Jackson:master
May 4, 2017
Merged

Update from experimental variables#28
dsifford merged 3 commits intodracula:masterfrom
Eric-Jackson:master

Conversation

@Eric-Jackson
Copy link
Copy Markdown
Contributor

@Eric-Jackson Eric-Jackson commented May 4, 2017

Before PR:
screen shot 2017-05-04 at 3 03 15 pm

After PR:
screen shot 2017-05-04 at 4 37 55 pm

@Eric-Jackson
Updated from experimental variables
f068bb5 
#27
@Eric-Jackson
Corrections
3fc9232 
Fixed a couple of missed properties.
@dsifford
Copy link
Copy Markdown
Member

dsifford commented May 4, 2017

@Eric-Jackson Looks good to me. Thanks!

Would you mind also updating the engines.vscode field in the package.json to ^1.12.0? And while you're there, throw your name in the contributors section as well 😄

Thanks so much!

@Eric-Jackson
Version bump and contributor added
bafdcfd 
Increased the supported vscode version number and added my name to
contributors.
@Eric-Jackson
Copy link
Copy Markdown
Contributor Author

Eric-Jackson commented May 4, 2017 •
edited
Loading

@dsifford Done and done. :)

@dsifford dsifford merged commit 45326ba into dracula:master May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eric-Jackson @dsifford