Skip to content

Be more nativwind compatible#1033

Merged
YoussefHenna merged 3 commits into
masterfrom
youssef/v2-2190-make-jigsaw-component-more-nativewind-friendly
May 27, 2026
Merged

Be more nativwind compatible#1033
YoussefHenna merged 3 commits into
masterfrom
youssef/v2-2190-make-jigsaw-component-more-nativewind-friendly

Conversation

@YoussefHenna
Copy link
Copy Markdown
Collaborator

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented May 26, 2026

V2-2190

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds className support and forwards rest props across several core components, including DeckSwiper, AudioPlayer, VideoPlayer, CircularProgress, LinearProgress, SwipeableItem, Swiper, and YoutubePlayer. The reviewer recommends simplifying the conditional ternary spread used to apply className (e.g., {...(className ? ({ className } as any) : {})}) by passing it directly as a prop (e.g., className={className as any}), which is cleaner and safe in React.

Comment thread packages/core/src/components/DeckSwiper/DeckSwiper.tsx Outdated
Comment thread packages/core/src/components/MediaPlayer/AudioPlayer/AudioPlayerWithInterface.tsx Outdated
Comment thread packages/core/src/components/MediaPlayer/VideoPlayer/VideoPlayer.tsx Outdated
Comment thread packages/core/src/components/Progress/CircularProgress/CircularProgress.tsx Outdated
Comment thread packages/core/src/components/Progress/LinearProgress/LinearProgress.tsx Outdated
Comment thread packages/core/src/components/SwipeableItem/SwipeableItem.tsx Outdated
Comment thread packages/core/src/components/YoutubePlayer/YoutubePlayer.tsx Outdated
@github-actions
Copy link
Copy Markdown

Published version: @draftbit/ui@54.0.4-982952.2

@YoussefHenna YoussefHenna merged commit 290dfd1 into master May 27, 2026
4 checks passed
@YoussefHenna YoussefHenna deleted the youssef/v2-2190-make-jigsaw-component-more-nativewind-friendly branch May 27, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant