Skip to content

Conversation

@YoussefHenna
Copy link
Collaborator

  • The TextField component code is a bit of mess, using padding, position, and margin in various places making it hard to find how everything is positioned.
  • This fixes the misalignment of the icon.
    • Not pretty, but works around the current codebase.
  • At some point, I should cleanup the code for this component.

@YoussefHenna YoussefHenna added the legacy For a legacy branch using an older Expo version label Sep 10, 2023
@linear
Copy link

linear bot commented Sep 10, 2023

P-4044 Icon misaligned in Picker and TextField

rahul said in P-3786:

This is very impressive youssef .

I do see one problem with left icon alignment

image.png

@github-actions
Copy link

Published version: @draftbit/ui@47.8.1-fe0dbc.2

@YoussefHenna YoussefHenna merged commit 352c60b into 47 Sep 10, 2023
@YoussefHenna YoussefHenna deleted the youssef/p-4044-icon-misaligned-in-picker-and-textfield47 branch September 10, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

legacy For a legacy branch using an older Expo version

Development

Successfully merging this pull request may close these issues.

3 participants