fix: ignore textTransform uppercase label of TabView #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoussefHenna
requested changes
Oct 4, 2023
Collaborator
YoussefHenna
left a comment
YoussefHenna
left a comment
There was a problem hiding this comment.
Thanks for fixing this, just a minor comment
YoussefHenna
approved these changes
Oct 4, 2023
YoussefHenna
pushed a commit
that referenced
this pull request
Oct 4, 2023
* fix: ignore textTransform uppercase of label * chore: reverse the order of label style --------- Co-authored-by: Sieu Thai <sieuthai@Sieus-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
File:
react-native-tab-view/TabBarItem.tsxforce label into uppercaseOverview
Demo
Closes https://linear.app/draftbit/issue/P-4149/not-able-to-make-capitalize-tab-view-title