✨ #49 define many DefaultDataProviders#82
Merged
drager merged 1 commit intodrager:masterfrom Jul 4, 2025
Merged
Conversation
- add ConferenceDataProvider - add PersonDefaultDataProvider - add DefaultCurrencyDataProvider - add DefaultFoodDataProvider - add DefaultSportsDataProvider - add DefaultJobDataProvider - add DefaultVehicleDataProvider
Contributor
Author
|
hi, @drager 😸 please review, thanks ! 😸 |
Contributor
Author
|
hi @drager 😄 I know you're busy, but I look forward to your continued reviews ! 😉 |
Contributor
Author
|
Hello ! I know you're busy, but I'd appreciate it if you could leave a review ! 😸 |
Contributor
Author
|
Hello ! 😄 I'm looking forward to your review of this PR ! 🙏🏻 As the issue says, I think this PR is needed by everyone, so I hope you will review it. 🫡 |
Contributor
Author
|
Hi @drager 😄 thanks for this pr merged 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some DefaultProviders based on #49.
I submitted a PR hoping to contribute to multilingual support even a little 😸
Once this is merged, we expect the Faker community to be able to work on supporting each locale in a decentralized manner 😉
sorry, I am Japanese and am not good at English, so I use Google Translate to communicate. 🙇🏻
Connection with issue(s)
Resolve issue #???
Connected to #30
Testing and Review Notes
You can check the test below to make sure that this change does not affect the original behavior.
(The test code has not been changed for this change.)
To Do
Special thanks
I think @easazade 's suggestion is a great step forward ! 😸