Skip to content

get rid of sds arguments in SortedMap #4639

@romange

Description

@romange

(good for starter tasks)

SortedMap still has some methods with sds because zset_family code uses sds and that in turn due to reliance on zzl utlilites like zzlFind

  1. We should reimplement zzl utilities using string_view instead of sds, (only those that we need of course),
    and use where they are needed in zset_family, similarly to how we implemented LpFind vs lpFind
  2. We should get rid of SdsWrap calls in zset_family and pass string_view directly.
  3. We should get rid of functions accepting sds arguments inside SortedMap.

An example PR that does such cleanup: #4638

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions