failed replication_test.py::test_replication_timeout_on_full_sync

[BorysTheDev]

https://github.com/dragonflydb/dragonfly/actions/runs/13892743446/job/38867312517

[BorysTheDev]

somehow we are stuck on the

  VLOG(1) << "Waiting for all full sync cut confirmations";
  sync_block->Wait();

next messages were done after terminating because sync_block->cancel() was called in err_handler

[BorysTheDev]

Possible cause: to cancel replication we use Cancel error, but the streamer in this case can skip the callback WaitForInflightToComplete check

void JournalStreamer::Cancel() {
  ...
  if (!cntx_->IsError()) {
    WaitForInflightToComplete();
  }
}

[kostasrim]

Possible cause: to cancel replication we use Cancel error, but the streamer in this case can skip the callback WaitForInflightToComplete check

void JournalStreamer::Cancel() {
  ...
  if (!cntx_->IsError()) {
    WaitForInflightToComplete();
  }
}

yes already aware of this. If you recall I was checking memory ordering around that synchronization primitive but IMO I think there is another issue.

[BorysTheDev]

yes already aware of this. If you recall I was checking memory ordering around that synchronization primitive but IMO I think there is another issue.

Agree. I just write about it to not forgetting in the future

[BorysTheDev]

I haven't found the main issue, so I've added more logs in #4848

[kostasrim]

Is it reproducible locally or on a similar aws instance ?

[BorysTheDev]

Is it reproducible locally or on a similar aws instance ?

no

[BorysTheDev]

Reproduces several more times:
https://github.com/dragonflydb/dragonfly/actions/runs/14145466576/job/39632257510
https://github.com/dragonflydb/dragonfly/actions/runs/14152126364/job/39646705505
https://github.com/dragonflydb/dragonfly/actions/runs/14153271907/job/39649240428