Download manager improvements#210
Merged
dragonflylee merged 4 commits intodragonflylee:devfrom Apr 24, 2026
Merged
Conversation
Init VideoProfile on MPV_RESUME for local downloads so F1 shows codec, resolution, bitrate and other playback metrics.
- Wire up context menu (F4/X) on episode cards in season view so episodes can be downloaded from the series page - Add Episode overload for ContextMenu and DownloadManager::addDownload to preserve series name and season/episode indices in download metadata - Fix MPV event subscription leak in offline playback overlay by unsubscribing on MPV_STOP to prevent use-after-free - Fix race in Episode addDownload where processQueue could start before episode metadata was persisted - Show Remote tab (with Downloads) in ServerList even without configured remotes, so downloaded media is accessible in airplane mode
Defer MPV event unsubscribe to next main-thread tick via brls::sync() to avoid iterator invalidation when erasing from the callback list while Event::fire() is still iterating it.
Handle all terminal MPV events (MPV_STOP, END_OF_FILE, MPV_FILE_ERROR) and guard with atomic flag to prevent calling profile->init() after the view is destroyed and to avoid erasing the same iterator twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #209. This addresses the immediate gaps mentioned there and fixes a few issues found during testing.