-
Notifications
You must be signed in to change notification settings - Fork 55
Remove redundant tracing module tests #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
…ards_structure Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
gaius-qi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
==========================================
+ Coverage 49.51% 50.25% +0.73%
==========================================
Files 82 82
Lines 19698 19809 +111
==========================================
+ Hits 9754 9955 +201
+ Misses 9944 9854 -90
🚀 New features to boost your workflow:
|
chlins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Removed three low-value test functions from the tracing module that provided minimal coverage:
.len()returns 0The remaining three tests provide meaningful coverage:
test_init_tracing_comprehensive- Validates tracing initialization, log directory creation, and guard lifecycletest_host_struct_can_be_created- Tests Host struct instantiation with proper field valuestest_temp_dir_and_file_creation- Validates filesystem operations for log pathsNet reduction: 33 lines
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.