Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

Removed three low-value test functions from the tracing module that provided minimal coverage:

  • test_span_exporter_timeout - Only validated a constant value
  • test_log_levels - Tested standard library enum comparison behavior
  • test_worker_guards_structure - Created empty vector and verified .len() returns 0

The remaining three tests provide meaningful coverage:

  • test_init_tracing_comprehensive - Validates tracing initialization, log directory creation, and guard lifecycle
  • test_host_struct_can_be_created - Tests Host struct instantiation with proper field values
  • test_temp_dir_and_file_creation - Validates filesystem operations for log paths

Net reduction: 33 lines

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 3, 2026 05:44
Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
Copilot AI changed the title [WIP] Add unit tests for dragonfly-client tracing Add unit tests for dragonfly-client/tracing module Feb 3, 2026
Copilot AI requested a review from gaius-qi February 3, 2026 05:58
Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
Copilot AI changed the title Add unit tests for dragonfly-client/tracing module Remove redundant comments from tracing test module Feb 3, 2026
…ards_structure

Co-authored-by: gaius-qi <15955374+gaius-qi@users.noreply.github.com>
Copilot AI changed the title Remove redundant comments from tracing test module Remove redundant tracing module tests Feb 3, 2026
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.25%. Comparing base (41f6c0d) to head (b10c84e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
+ Coverage   49.51%   50.25%   +0.73%     
==========================================
  Files          82       82              
  Lines       19698    19809     +111     
==========================================
+ Hits         9754     9955     +201     
+ Misses       9944     9854      -90     
Files with missing lines Coverage Δ
dragonfly-client/src/tracing/mod.rs 50.20% <100.00%> (+50.20%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 4, 2026
@gaius-qi gaius-qi added this to the v2.5.0 milestone Feb 4, 2026
@gaius-qi gaius-qi marked this pull request as ready for review February 4, 2026 02:27
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 9df26f6 into main Feb 4, 2026
8 of 9 checks passed
@gaius-qi gaius-qi deleted the copilot/add-dragonfly-client-tracing-tests branch February 4, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants