Skip to content

chore(proxy): print request safety in proxy#1715

Open
CooooolFrog wants to merge 6 commits intodragonflyoss:mainfrom
CooooolFrog:main
Open

chore(proxy): print request safety in proxy#1715
CooooolFrog wants to merge 6 commits intodragonflyoss:mainfrom
CooooolFrog:main

Conversation

@CooooolFrog
Copy link

Description

This PR addresses a potential security problem mentioned in this issue (#1559) by changing the output logs for request-related data from the info level to the debug level, thus preventing the direct output of sensitive information.

Related Issue

#1559

@CooooolFrog CooooolFrog force-pushed the main branch 2 times, most recently from 9d5f49f to b344a49 Compare March 11, 2026 08:16
@CooooolFrog CooooolFrog requested a review from gaius-qi March 11, 2026 08:16
@CooooolFrog CooooolFrog added the bug Something isn't working label Mar 11, 2026
@CooooolFrog CooooolFrog force-pushed the main branch 2 times, most recently from ac87ca5 to b49fb44 Compare March 11, 2026 08:38
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.21%. Comparing base (c6a2b95) to head (16a938f).

Files with missing lines Patch % Lines
dragonfly-client/src/proxy/mod.rs 0.00% 21 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
- Coverage   50.29%   50.21%   -0.08%     
==========================================
  Files          86       86              
  Lines       21977    21998      +21     
==========================================
- Hits        11053    11046       -7     
- Misses      10924    10952      +28     
Files with missing lines Coverage Δ
dragonfly-client/src/proxy/mod.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: CooooolFrog <zuliangwanghust@gmail.com>
Signed-off-by: CooooolFrog <zuliangwanghust@gmail.com>
Signed-off-by: CooooolFrog <zuliangwanghust@gmail.com>
Signed-off-by: CooooolFrog <zuliangwanghust@gmail.com>
Signed-off-by: CooooolFrog <zuliangwanghust@gmail.com>
Signed-off-by: CooooolFrog <zuliangwanghust@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant