Skip to content

refactor: rename get_persistent_tasks to `get_persistent_cache_tasks#1795

Merged
gaius-qi merged 1 commit intomainfrom
feature/persistent
Apr 15, 2026
Merged

refactor: rename get_persistent_tasks to `get_persistent_cache_tasks#1795
gaius-qi merged 1 commit intomainfrom
feature/persistent

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

@gaius-qi gaius-qi commented Apr 15, 2026

Description

This pull request makes a small but important fix to the PersistentCacheTask implementation, correcting a method call to ensure the correct retrieval of persistent cache tasks from local storage.

  • Changed the method call from get_persistent_tasks() to get_persistent_cache_tasks() in the list_local function to accurately fetch persistent cache tasks from local storage.

Related Issue

Fixes #1793

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.5.0 milestone Apr 15, 2026
@gaius-qi gaius-qi self-assigned this Apr 15, 2026
@gaius-qi gaius-qi added the enhancement New feature or request label Apr 15, 2026
@gaius-qi gaius-qi requested review from a team as code owners April 15, 2026 03:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.21%. Comparing base (f54846b) to head (1a38a69).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onfly-client/src/resource/persistent_cache_task.rs 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1795   +/-   ##
=======================================
  Coverage   43.21%   43.21%           
=======================================
  Files          92       92           
  Lines       26868    26868           
=======================================
  Hits        11612    11612           
  Misses      15256    15256           
Files with missing lines Coverage Δ
...onfly-client/src/resource/persistent_cache_task.rs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@BraveY BraveY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 9011023 into main Apr 15, 2026
9 checks passed
@gaius-qi gaius-qi deleted the feature/persistent branch April 15, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dfctl persistent-cache-task shows empty

3 participants