Skip to content

fix(backend): include full error chain in stream IO errors#1806

Merged
gaius-qi merged 1 commit intomainfrom
feature/stream-error
Apr 27, 2026
Merged

fix(backend): include full error chain in stream IO errors#1806
gaius-qi merged 1 commit intomainfrom
feature/stream-error

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

Description

This pull request updates the workspace version to 1.3.7 and improves error handling in HTTP response reading for multiple backends. The main changes are upgrading internal dependencies to the new version and enhancing error reporting by including chained error messages, which should make debugging easier.

Dependency version updates:

  • Updated the workspace version and all internal dragonfly-client-* dependencies from 1.3.6 to 1.3.7 in Cargo.toml. [1] [2]

Error handling improvements:

  • In dragonfly-client-backend/src/http.rs, hugging_face.rs, and model_scope.rs, improved error reporting in the response stream reader by chaining error messages from all underlying sources, making errors more descriptive and easier to trace. [1] [2] [3] [4] [5] [6]

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.5.0 milestone Apr 27, 2026
@gaius-qi gaius-qi self-assigned this Apr 27, 2026
@gaius-qi gaius-qi requested review from a team as code owners April 27, 2026 04:08
@gaius-qi gaius-qi requested review from bergwolf and mingcheng April 27, 2026 04:08
@gaius-qi gaius-qi added the enhancement New feature or request label Apr 27, 2026
Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi enabled auto-merge (squash) April 27, 2026 04:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.43%. Comparing base (9926bfe) to head (4aab435).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client-backend/src/hugging_face.rs 0.00% 13 Missing ⚠️
dragonfly-client-backend/src/model_scope.rs 0.00% 13 Missing ⚠️
dragonfly-client-backend/src/http.rs 0.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
- Coverage   43.44%   43.43%   -0.02%     
==========================================
  Files          92       92              
  Lines       26972    26997      +25     
==========================================
+ Hits        11719    11726       +7     
- Misses      15253    15271      +18     
Files with missing lines Coverage Δ
dragonfly-client-backend/src/http.rs 96.07% <0.00%> (-1.05%) ⬇️
dragonfly-client-backend/src/hugging_face.rs 35.04% <0.00%> (-0.46%) ⬇️
dragonfly-client-backend/src/model_scope.rs 42.21% <0.00%> (-0.52%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi merged commit 7ecfcf3 into main Apr 27, 2026
9 checks passed
@gaius-qi gaius-qi deleted the feature/stream-error branch April 27, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants