Skip to content

fix(gc): increase download task timeout from 2 hours to 24 hours#1816

Merged
gaius-qi merged 1 commit intomainfrom
feature/timeout
Apr 28, 2026
Merged

fix(gc): increase download task timeout from 2 hours to 24 hours#1816
gaius-qi merged 1 commit intomainfrom
feature/timeout

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

@gaius-qi gaius-qi commented Apr 28, 2026

Description

This pull request makes a single, straightforward change to the garbage collection behavior in the dragonfly-client codebase. The timeout for download tasks before they are considered for garbage collection has been increased from 2 hours to 24 hours.

  • Increased the DOWNLOAD_TASK_TIMEOUT constant in gc/mod.rs from 2 hours to 24 hours, allowing download tasks to persist longer before being garbage collected.

Related Issue

Fixes #1815

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.5.0 milestone Apr 28, 2026
@gaius-qi gaius-qi self-assigned this Apr 28, 2026
@gaius-qi gaius-qi requested review from a team as code owners April 28, 2026 09:51
@gaius-qi gaius-qi added the enhancement New feature or request label Apr 28, 2026
@gaius-qi gaius-qi enabled auto-merge (squash) April 28, 2026 09:51
@github-actions github-actions Bot requested review from hyy0322 and jim3ma April 28, 2026 09:51
Copy link
Copy Markdown
Member

@EvanCley EvanCley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi disabled auto-merge April 28, 2026 09:53
@gaius-qi gaius-qi enabled auto-merge (squash) April 28, 2026 09:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.53%. Comparing base (7ecfcf3) to head (9bd2411).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
+ Coverage   43.40%   43.53%   +0.12%     
==========================================
  Files          92       92              
  Lines       26997    26917      -80     
==========================================
  Hits        11719    11719              
+ Misses      15278    15198      -80     
Files with missing lines Coverage Δ
dragonfly-client/src/gc/mod.rs 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi merged commit 1f448d5 into main Apr 28, 2026
9 checks passed
@gaius-qi gaius-qi deleted the feature/timeout branch April 28, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make DOWNLOAD_TASK_TIMEOUT configurable for long-running downloads in poor network conditions

5 participants