fix: Preserve SigV4 range through dfdaemon proxy#1820
Open
YQ-Wang wants to merge 2 commits intodragonflyoss:mainfrom
Open
fix: Preserve SigV4 range through dfdaemon proxy#1820YQ-Wang wants to merge 2 commits intodragonflyoss:mainfrom
YQ-Wang wants to merge 2 commits intodragonflyoss:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1820 +/- ##
==========================================
+ Coverage 43.58% 44.28% +0.69%
==========================================
Files 92 92
Lines 26929 27376 +447
==========================================
+ Hits 11738 12124 +386
- Misses 15191 15252 +61
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes s5cmd multipart S3 downloads through dfdaemon's HTTP proxy when the request signs the Range header with AWS SigV4.
Changes include:
Related Issue
#1821
Motivation and Context
s5cmd uses multipart ranged GetObject requests for downloads. With AWS SigV4, those requests include range in SignedHeaders. dfdaemon's proxy normally rewrites Range when fetching pieces from the source, which changes the canonical request and causes S3 to reject the request with 403 SignatureDoesNotMatch.
This change keeps the fix narrow: it only preserves Range when the request's authentication material explicitly signs it. Other proxy downloads continue through the existing piece-splitting path.
Tests