Skip to content

feat: Modify the preheat parameter to filteredQueryParams#351

Merged
gaius-qi merged 1 commit intomainfrom
feat--Modify-the-preheat-parameter-to-filteredQueryParams
Jan 25, 2024
Merged

feat: Modify the preheat parameter to filteredQueryParams#351
gaius-qi merged 1 commit intomainfrom
feat--Modify-the-preheat-parameter-to-filteredQueryParams

Conversation

@Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Jan 25, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: zhaoxinxin <1186037180@qq.com>
@Liam-Zhao Liam-Zhao added the enhancement New feature or request label Jan 25, 2024
@Liam-Zhao Liam-Zhao self-assigned this Jan 25, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner January 25, 2024 10:04
@Liam-Zhao Liam-Zhao changed the title feat: Modify preheat parameters feat: Modify the preheat parameter to filteredQueryParams Jan 25, 2024
@codecov
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e72aab0) 0.00% compared to head (92ba853) 98.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #351       +/-   ##
=========================================
+ Coverage      0   98.42%   +98.42%     
=========================================
  Files         0       27       +27     
  Lines         0     2790     +2790     
  Branches      0      793      +793     
=========================================
+ Hits          0     2746     +2746     
- Misses        0       43       +43     
- Partials      0        1        +1     
Files Coverage Δ
src/components/job/preheats/new.tsx 99.39% <100.00%> (ø)
src/components/job/preheats/show.tsx 99.00% <100.00%> (ø)
src/lib/api.ts 93.47% <ø> (ø)

... and 24 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit b21bf03 into main Jan 25, 2024
@gaius-qi gaius-qi deleted the feat--Modify-the-preheat-parameter-to-filteredQueryParams branch January 25, 2024 12:05
Yang1998-jiale pushed a commit that referenced this pull request Mar 11, 2026
feat: Modify preheat parameters

Signed-off-by: zhaoxinxin <1186037180@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants