Skip to content

Conversation

@gaius-qi
Copy link
Member

Description

This pull request introduces benchmarking for the Vortex library by adding a new benchmark suite and updating the Cargo.toml file to include necessary dependencies. The most important changes include the addition of benchmark functions for packet creation, serialization, and deserialization, as well as the inclusion of the criterion library for benchmarking.

Benchmarking additions:

  • benches/vortex.rs: Added benchmark functions for Vortex packet creation, serialization, and deserialization for various packet sizes (32 bytes to 128 MB).

Dependency updates:

  • Cargo.toml: Added criterion as a development dependency and configured the benchmark suite.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Jan 14, 2025
@gaius-qi gaius-qi self-assigned this Jan 14, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner January 14, 2025 11:12
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@CormickKneey CormickKneey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit d58862b into main Jan 14, 2025
5 checks passed
@gaius-qi gaius-qi deleted the feature/benches branch January 14, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants