Replace fixed header buffer with dynamic ArrayList in sendHttpRequest#4
Merged
dragosv merged 2 commits intounixsocketfrom Mar 5, 2026
Merged
Replace fixed header buffer with dynamic ArrayList in sendHttpRequest#4dragosv merged 2 commits intounixsocketfrom
dragosv merged 2 commits intounixsocketfrom
Conversation
Merged
Co-authored-by: dragosv <422243+dragosv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on using unix sockets from pull request review
Replace fixed header buffer with dynamic ArrayList in sendHttpRequest
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendHttpRequestused a fixed 4096-byte stack buffer for building HTTP request headers. Requests with long paths orContent-Typevalues could exhaust the buffer, returningerror.NoSpaceLeftinstead of sending the request.Description
Replaces the fixed
[4096]u8+fixedBufferStreamwithstd.ArrayList(u8)that grows on demand. The function gains anallocator: std.mem.Allocatorparameter; callers pass theirself.allocator.Before:
After:
doRequest,imagePull, andpingupdated to passself.allocatorstd.testing.allocatorType of Change
Checklist
Testing
Existing
sendHttpRequestunit tests pass withstd.testing.allocatorsubstituted for the removed stack buffer.Additional Notes
Internal function signature change only — no public API impact.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.