Fix RFC 7230 §3.3.3 violation: Transfer-Encoding takes precedence over Content-Length#5
Merged
dragosv merged 3 commits intounixsocketfrom Mar 5, 2026
Merged
Conversation
Merged
…7230 §3.3.3 Co-authored-by: dragosv <422243+dragosv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on UNIX sockets implementation
Fix RFC 7230 §3.3.3 violation: Transfer-Encoding takes precedence over Content-Length
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both
Transfer-Encoding: chunkedandContent-Lengthheaders are present,readResponseBodywas checkingcontent_lengthfirst — violating RFC 7230 §3.3.3, which mandates that Transfer-Encoding takes precedence and Content-Length must be ignored.Description
Reorder the checks in
readResponseBodysometa.chunkedis evaluated beforemeta.content_length:Added a
///doc comment citing the RFC so the ordering intent is self-documenting.Type of Change
Checklist
Testing
Additional Notes
This is a correctness fix for an edge case (server sending both headers). Docker's own API is well-behaved, but the fix ensures correct behaviour against any RFC-conformant or buggy intermediary.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.