Extract Git info at build time only if possible #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build system tries to extract some Git build details (e.g. branch and SHA). The problem is that it assumes that both 'git' is installed, and that the sources are in a Git repository: while this is true during a Git build, they are both not true when building from release tarballs (e.g. as done by distributions). Hence, manually search for 'git' and that the current sources are a Git repository: - if both are valid, extract the build details as done so far - if neither is available, still try to use '.tag' for the SHA, setting the value for the branch as well to it
Owner
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build system tries to extract some Git build details (e.g. branch and SHA). The problem is that it assumes that both
gitis installed, and that the sources are in a Git repository: while this is true during a Git build, they are both not true when building from release tarballs (e.g. as done by distributions).Hence, manually search for
gitand that the current sources are a Git repository:.tagfor the SHA, setting the value for the branch as well to it