in get_support_bundle assign value to error variable also in success path #202
Merged
in get_support_bundle assign value to error variable also in success path #202
Conversation
hectorgarzon
requested review from
janoe,
mbreitung,
pablo-calvo,
ph-sysdig and
saltycr3w
janoe
approved these changes
Jul 7, 2022
pablo-calvo
approved these changes
Jul 7, 2022
mbreitung
approved these changes
Jul 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_support_bundle.sh was failing in the jobs complaining about:
line 144: error: unbound variableMore details in this ticket: https://sysdig.atlassian.net/browse/QA-4702
We are just assigning value 0 to variable
erroras it seems that it doesn't have a default value on declaration