Conversation
I have changed most of kubectl get pods commands to print out only the pod name directly by using "-o custom-columns=NAME:metadata.name" instead of using awk. Before approving the PR is worth doing a quick test on different k8s version, I have test it only on k8s 1.23
Contributor
|
@dark-vex can you resolve conflicts here and then we can work on getting it merged please? |
Contributor
Author
|
@dthomson-sysdig I have resolved the conflicts ;) |
Contributor
|
@dark-vex can you merge master please as we need to do the same for kafka/zookeeper storage gathering? |
Contributor
Author
|
Sure absolutely, @dthomson-sysdig I have rebased my branch and I have introduced the change for kafka+zookeeper storage gathering. I have also updated the ES one: I checked if there is anything else missing but it doesn't seems but in case let me know |
saltycr3w
approved these changes
Jun 27, 2023
mbreitung
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have changed most of kubectl get pods commands to print out only the pod name directly by using "-o custom-columns=NAME:metadata.name" instead of using awk.
Before approving the PR is worth doing a quick test on different k8s version, I have test it only on k8s 1.23