Remove hard sudo requirement#91
Merged
mbreitung merged 1 commit intodraios:masterfrom Feb 13, 2020
Merged
Conversation
The script will fail immediately with the message "Please install sudo and re-run the script" if sudo is not present in the shell, like in some Docker containers. Sudo is only required for installing curl if it is not present, and since the [official IBM docs recommend downloading the script via curl](https://cloud.ibm.com/docs/services/Monitoring-with-Sysdig?topic=Sysdig-config_agent#config_agent_linux), most users won't ever hit that codepath.
Contributor
Author
|
Thanks @bennythejudge - who should I assign as the second reviewer? |
mbreitung
approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script will fail immediately with the message "Please install sudo and re-run the script" if sudo is not present in the shell, like in some Docker containers. Sudo is only required for installing curl if it is not present, and since the official IBM docs recommend downloading the script via curl, most users won't ever hit that codepath.