Conversation
mbreitung
reviewed
Mar 18, 2020
mbreitung
reviewed
Mar 18, 2020
mbreitung
reviewed
Mar 18, 2020
mbreitung
reviewed
Mar 18, 2020
krishnan-ramkumar
previously approved these changes
Mar 18, 2020
Contributor
krishnan-ramkumar
left a comment
krishnan-ramkumar
left a comment
There was a problem hiding this comment.
Looks good to me by and large. The only thing I don't agree with is giving the daemonset a v1 name --- we don't yet know if we ever need to have a v2 and if we do, then we can rename this guy to v1 at that time.
For now it can just be sysdig-image-analyzer-daemonset.yaml
| name: sysdig-image-analyzer | ||
| key: cri_socket_path | ||
| optional: true | ||
| - name: AM_COLLECTOR_ENDPOINT |
Contributor
There was a problem hiding this comment.
I know this is an env variable and not related to the variable in the single line script -- but just a note to double check this variable given we changed the name in the other script.
Contributor
|
@krishnan-ramkumar makes sense, updated the file name to |
mbreitung
previously approved these changes
Mar 19, 2020
krishnan-ramkumar
previously approved these changes
Mar 19, 2020
mattpag
approved these changes
Mar 19, 2020
mbreitung
approved these changes
Mar 19, 2020
krishnan-ramkumar
approved these changes
Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds to the main branch the new Node Image Analyzer kubernetes scripts.
The Node Image Analyzer component can be run on customer's clusters and can use an engine to automatically scan all images associated with any running container on the cluster and send the report to the Sysdig backend.