Bump draios/sysdig to v0.35.1#172
Merged
Merged
Conversation
mattnite
force-pushed
the
bump-sysdig-0.35.1
branch
from
37fb5ee to
e984db5
Compare
jasondellaluce
approved these changes
Feb 8, 2024
jasondellaluce
left a comment
jasondellaluce
left a comment
There was a problem hiding this comment.
cc @therealbobo we'd likely want to issue a new release, please provide context on how that works to Matt since you've been the last one refactoring the pipeline
therealbobo
approved these changes
Feb 8, 2024
Contributor
|
The release process is exactly the same of @mattnite you are missing the |
mattnite
force-pushed
the
bump-sysdig-0.35.1
branch
from
e984db5 to
4533906
Compare
Contributor
Author
|
For pushing the tag, is that something you'll do once it gets merged, or is that something I should do? |
Contributor
Author
|
@therealbobo ping |
mattnite
force-pushed
the
bump-sysdig-0.35.1
branch
from
4533906 to
a0e6059
Compare
sysdig-CLA-1.0-signed-off-by: Matthew Knight <matthew.knight@sysdig.com> Signed-off-by: Matthew Knight <matthew.knight@sysdig.com>
mattnite
force-pushed
the
bump-sysdig-0.35.1
branch
from
a0e6059 to
c79ac6f
Compare
|
Contributor
Author
|
Nvm I realize that I needed to sign my commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that my LSP caught some trailing whitespace as well, let me know if I should drop those diffs from the patch