Skip to content

Add Support for signatures on the G2 curve for BDN#53

Merged
AnomalRoil merged 8 commits intodrand:masterfrom
matejpavlovic:bdn-on-g2
Mar 8, 2024
Merged

Add Support for signatures on the G2 curve for BDN#53
AnomalRoil merged 8 commits intodrand:masterfrom
matejpavlovic:bdn-on-g2

Conversation

@matejpavlovic
Copy link
Copy Markdown

Feel free to further edit the code in this PR, in particular adding proper tests.

Comment thread sign/bdn/bdn.go Outdated
@matejpavlovic
Copy link
Copy Markdown
Author

I would also like to mention that my understanding of the code is still rather superficial. This shows, for example, that I did not manage to generalize the unit tests. Please make sure that the code actually works before merging. Thanks!

@Stebalien Stebalien mentioned this pull request Feb 20, 2024
@Kubuxu
Copy link
Copy Markdown

Kubuxu commented Mar 4, 2024

Hey @AnomalRoil let me know what needs to get done to get this merged.

@AnomalRoil
Copy link
Copy Markdown
Member

It needs more tests I guess, which has been on my to-do for like 2 months 😅

@Kubuxu
Copy link
Copy Markdown

Kubuxu commented Mar 6, 2024

While working on more tests, I discovered that hashToPoint is not implemented on bn256 G2 Point.
See the PR to upstream kyber: https://github.com/dedis/kyber/pull/428/files

This is not an issue with bls12381 we are using.

@Kubuxu
Copy link
Copy Markdown

Kubuxu commented Mar 6, 2024

Pull in Kubuxu@c5d6a11 for additional tests

Kubuxu and others added 2 commits March 7, 2024 02:32
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
@AnomalRoil
Copy link
Copy Markdown
Member

I just need to add some retro-compat functions to avoid breaking public APIs and I'll release a new minor release with this 👍🏻

@AnomalRoil AnomalRoil merged commit 266eb7b into drand:master Mar 8, 2024
@matejpavlovic matejpavlovic deleted the bdn-on-g2 branch March 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants