Use Ubuntu 22.04 image to fix broken Ruby 2.4 build #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu-latest workflows use Ubuntu-24.04 image now. actions/runner-images#10636 But, itt seems that old sqlite3 gem(for Ruby 2.4) doesn't work with it. https://github.com/drapergem/draper/actions/runs/12762245525/job/35570471534?pr=940 So I fixed it to use Ubuntu 22.04
y-yagi
force-pushed
the
fix_ruby24_build
branch
from
7230abc to
0716860
Compare
y-yagi
changed the title
Alexander-Senko
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu-latest workflows use Ubuntu-24.04 image now.
actions/runner-images#10636
But, it seems that old sqlite3 gem(for Ruby 2.4) doesn't work with it.
https://github.com/drapergem/draper/actions/runs/12762245525/job/35570471534?pr=940
So I fixed it to use Ubuntu 22.04. It may be better to use Ubuntu 22.04 only for Ruby 2.4. But, it would be complex.
Ubuntu 22.04 will be supported by Apr 2027. So it's OK to keep using it so far(And we should drop old Ruby versions before that).