Remove the leading > in recipe command#42
Merged
Merged
Conversation
After introducing parameters <p1:v1,...>, doing $(VAR:>=) to remove the leaving > in a recipe command is only possible if we make sure that after the closing > there is no space (see the comments about "at the end of a word" in section 6.3.1 Substitution References of the GNU Make manual. This is very brittle. Furthermore, while starting the command line with > seems clear, it is a disaster waiting to happen because making the "wrong" echo might redirect to something important. This commit also removes a comment I made about RECIPE_COMMAND_LINE -- which was wrong (on som any levels).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #41