feat: synthesize scoreboard findings from ares domain compromise metadata#201
Merged
Merged
Conversation
**Added:** - Added aresDomainCompromise struct to capture domain compromise metadata from ares loot JSON, including krbtgt extraction and golden ticket detection - Implemented synthesis of findings from domain_compromise[] in synthesizeJSONL to ensure domains compromised solely via krbtgt are recognized, with symbolic evidence for krbtgt extraction and golden_ticket technique - Added TestSynthesizeJSONLDomainCompromise to verify that domains compromised via krbtgt extraction are properly inferred and that only appropriate domains yield synthetic findings **Changed:** - Extended jqFilter in FetchReport to include domain_compromise array in the extracted JSON for more comprehensive reporting
**Changed:** - Updated command short descriptions to use "scoreboard" instead of "status board" for clarity in cli/cmd/scoreboard.go - Changed panel title in TUI from "STATUS BOARD" to "SCOREBOARD" to match updated terminology in cli/internal/scoreboard/tui.go - Revised demo command description for consistency with new terminology in cli/cmd/scoreboard.go
**Added:** - Introduced helper functions `writeJSONLEntry`, `writeCredentialEntry`, `writeHashEntry`, `writeExploitedEntries`, and `writeDomainCompromiseEntries` to modularize and clarify JSONL entry construction logic in `transport_ares.go` **Changed:** - Refactored `synthesizeJSONL` to use new helper functions, improving readability and maintainability by reducing code repetition and clarifying each logical step - Updated comments to document the purpose and behavior of new helper functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Added:
Changed: