Fix CI, add 147 tests, clean up code duplication#173
Merged
GangGreenTemperTatum merged 2 commits intomainfrom Feb 24, 2026
Merged
Fix CI, add 147 tests, clean up code duplication#173GangGreenTemperTatum merged 2 commits intomainfrom
GangGreenTemperTatum merged 2 commits intomainfrom
Conversation
dreadnode-renovate-bot
bot
added
area/pre-commit
- Regenerate poetry.lock to fix CI sync issue - Disable python version updates in Renovate config - Extract shared utils (sizeof_fmt, delta_fmt, count_package_prefixes) into dyana/utils.py - Extract SECURITY_EVENTS constant into dyana/constants.py - Replace module-level docker.from_env() with lazy _get_client() to prevent import-time crashes in CI (no Docker daemon required at import time) - Guard Loader import in view.py with TYPE_CHECKING to break unnecessary import chain - Fix unhashable dict bug in view_security_events (set comprehension → list) - Remove dead commented-out code from tracee.py, loader.py, pip/main.py - Add comprehensive test suite: 155 tests across 9 test files covering cli, utils, docker, view, view_legacy, tracee, loader, settings, and base/dyana - Add .pre-commit-config.yaml with ruff and pre-commit-hooks - Expand settings_test.py with 12 additional edge case tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
GangGreenTemperTatum
force-pushed
the
overhaul/ci-tests-cleanup
branch
from
81a3d50 to
2c04c36
Compare
Rich/Typer emits ANSI color codes in CI, causing string assertions on --help output to fail. Strip them before matching. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poetry.lockto resolve out-of-sync dependency issue; disable python version updates in Renovate configsizeof_fmt,delta_fmt,count_package_prefixes) intodyana/utils.py; extractSECURITY_EVENTSintodyana/constants.py; replace module-leveldocker.from_env()with lazy_get_client()to prevent import-time crashes without Docker; guardLoaderimport withTYPE_CHECKING; fix unhashable dict bug inview_security_events; remove dead commented-out code.pre-commit-config.yamlwith ruff linter/formatter and pre-commit-hooksTest plan
ruff check dyana— lint cleanmypy --ignore-missing-imports --no-error-summary dyana— type check cleanpytest dyana -v— all 155 tests pass--help,trace --help,summary --help,summarywith modern/legacy tracesview.py,view_legacy.py,docker.py,loader.py,tracee.pyall import without Docker daemon🤖 Generated with Claude Code