fix: Fix S3 credential auto-refresh mechanism and extend buffer window #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the S3 credential management system to resolve race conditions and improve reliability during long-running operations.
Key Changes:
CredentialManagerclass for centralized s3 credential lifecycle managementAdded:
CredentialManagerclass with automatic refresh detection and retry logicChanged:
-Migrated
ArtifactStorageandRunSpanto use centralized credential managerRemoved:
storage_utils.pydecorator-based refresh mechanismS3FileSystemparameter passing in span constructorsTesting: Validated with 1.40 hour continuous operation - credential refreshes occurred seamlessly without interruption to ongoing uploads and operations.
Generated Summary:
ArtifactStorageto utilizeCredentialManagerfor handling S3 credentials, improving management of authentication.with_credential_refreshdecorator and corresponding methods for credential refreshing, simplifying error handling.CredentialManagerclass to manage S3 credentials, incorporating automatic refresh logic.FS_CREDENTIAL_REFRESH_BUFFERfrom 5 to 15 minutes to allow a longer window before refreshing credentials.ArtifactStorageandRunSpanto useCredentialManager, including operations for storing files and batch uploads.storage_utils.pyfile as its functionality is now integrated into theCredentialManager.1.13.3to reflect changes.This summary was generated with ❤️ by rigging