Skip to content

chore: linting#21

Merged
briangreunke merged 1 commit into
v1from
brian/eng-1792-chore-linting-fixes
Apr 24, 2025
Merged

chore: linting#21
briangreunke merged 1 commit into
v1from
brian/eng-1792-chore-linting-fixes

Conversation

@briangreunke
Copy link
Copy Markdown
Contributor

@briangreunke briangreunke commented Apr 24, 2025

  • updated ruff version
  • marked noqa for existing errors for future work
  • fixed hooks linting errors
  • updated config for test and hook linting excludes

Generated Summary:

  • Refactored regex pattern definition for unpinned actions in check_pinned_hash_dependencies.py to use multi-line string for clarity.
  • Enhanced exception handling in generate_pr_description.py for subprocess errors when running git commands, specifically for FileNotFoundError, OSError, and asyncio.SubprocessError.
  • Improved readability of error messages in generate_pr_description.py by raising more precise exceptions.
  • Adjusted the casting in merger.py for type hints to use string types for better clarity in type safety.
  • Modified client.py to standardize string quotation for better consistency.
  • Updated the version of fsspec in pyproject.toml to ensure compatibility with datasets.
  • Increased the version of ruff and added additional ignored error codes in configuration to maintain coding standards and optimization.
  • Minor formatting improvements throughout various files for code consistency.

This summary was generated with ❤️ by rigging

- updated ruff version
- marked noqa for existing errors for future work
- fixed hooks linting errors
- updated config for test and hook linting excludes
@linear
Copy link
Copy Markdown

linear Bot commented Apr 24, 2025

ENG-1792 chore: linting fixes

Fix linting issues breaking CI job

@briangreunke briangreunke merged commit d9386ee into v1 Apr 24, 2025
2 checks passed
@monoxgas monoxgas deleted the brian/eng-1792-chore-linting-fixes branch April 25, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant