Merged
Conversation
The bundled JSHint fork in ace-builds 1.24.2 (still present
unchanged in 1.43.6) never plumbs state.option.module into the
prefix("await", ...) handler, so a /* jshint module: true */
directive is silently ignored for top-level await expressions in
the MCP custom tool function body editor. The handler falls into
its "treat await as identifier" branch and produces a misleading
"Missing ';' before statement." error on otherwise valid code.
Patch the minified worker so the handler takes a module-mode
path that parses the await operand as an expression without
requiring a surrounding async function. Async-function behavior
is unchanged.
Customers can now write:
/* jshint esversion: 11, module: true */
const res = await fetch(...);
in the custom tool function body editor and get clean linting.
Runtime was already fine — the daemon wraps the body in an
async IIFE at custom-tools.service.ts, so this was purely a
cosmetic editor warning, but a disruptive one.
A marker comment is prepended to worker-javascript.js so future
ace-builds upgrades know to re-audit this patch.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.