Skip to content

Fix Reset/Submit buttons always enabled in system settings#1004

Merged
Tim020 merged 2 commits into
devfrom
fix/settings-buttons-disabled-state
May 8, 2026
Merged

Fix Reset/Submit buttons always enabled in system settings#1004
Tim020 merged 2 commits into
devfrom
fix/settings-buttons-disabled-state

Conversation

@Tim020
Copy link
Copy Markdown
Contributor

@Tim020 Tim020 commented May 8, 2026

Summary

  • Closes System Config Settings buttons not behaving correctly #1003
  • Adds a hasChanges computed property to ConfigSettings.vue that compares current editSettings values against the stored RAW_SETTINGS values
  • Binds :disabled="!hasChanges" to both the Reset and Submit buttons so they are only enabled when there are actual unsaved changes
  • Reverting a setting to its original value correctly disables both buttons again

Test plan

  • Load the settings page — both buttons are disabled
  • Change a setting — both buttons become enabled
  • Change the setting back to its original value — both buttons disable again
  • Change multiple settings, revert some but not all — buttons remain enabled
  • Click Reset — form reverts, both buttons disable
  • Click Submit after making a change — settings save successfully

🤖 Generated with Claude Code

Both buttons now disable when no settings differ from their stored values,
and re-enable as soon as any value changes — reverting a setting back to
its original value correctly disables them again.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added client Pull requests changing front end code xsmall-diff labels May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Client Test Results

106 tests  ±0   106 ✅ ±0   0s ⏱️ ±0s
  5 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0a6ca27. ± Comparison against base commit 08be26e.

♻️ This comment has been updated with latest results.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Python Test Results

  1 files  ±0    1 suites  ±0   1m 20s ⏱️ +2s
587 tests ±0  587 ✅ ±0  0 💤 ±0  0 ❌ ±0 
592 runs  ±0  592 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0a6ca27. ± Comparison against base commit 08be26e.

♻️ This comment has been updated with latest results.

@github-actions github-actions Bot added small-diff Small pull request and removed xsmall-diff labels May 8, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

@Tim020 Tim020 enabled auto-merge (squash) May 8, 2026 22:23
@Tim020 Tim020 merged commit 14664e2 into dev May 8, 2026
25 checks passed
@Tim020 Tim020 deleted the fix/settings-buttons-disabled-state branch May 8, 2026 22:26
@Tim020 Tim020 linked an issue May 9, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests changing front end code small-diff Small pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System Config Settings buttons not behaving correctly

1 participant