Vue 3 migration: Phase 6 — show configuration foundation#1043
Merged
Conversation
- Add stores/show.ts: full Pinia port of V2 show Vuex module (cast, characters, character groups, acts, scenes, cue types, sessions, microphones, mic allocations, script modes, session tags, stageManagerMode persisted via pinia-plugin-persistedstate) - Add js/micConflictUtils.ts: mic conflict detection utilities (ported from V2) - Add views/show/ShowConfigView.vue: sticky vertical nav sidebar + RouterView shell - Wire /show-config parent route to ShowConfigView.vue (was PlaceholderView) - Move scriptModes state/action from system.ts to show.ts; update ConfigShows.vue - Fill in GET_CAST_LIST, ELECTED_LEADER, NO_LEADER, SCRIPT_SCROLL WS action handlers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stores/show.ts— full Pinia port of V2's 850-line Vuex show module: cast, characters, character groups, acts, scenes, cue types, sessions, microphones, mic allocations, script modes, session tags;stageManagerModepersisted viapinia-plugin-persistedstatejs/micConflictUtils.ts— mic conflict detection utilities (verbatim copy from V2client/src/js/micConflictUtils.ts)views/show/ShowConfigView.vue— sticky vertical<BButtonGroup>nav sidebar (col-1) +<RouterView>(col-11); permission-based button disabling; redirect logic for role-restricted users (fixes V2 double-redirect bug by redirecting only toshow-config-script-revisions)router/index.ts— wire/show-configparent route toShowConfigView.vue(wasPlaceholderView)stores/system.ts— removescriptModesstate/action (moved toshow.ts)components/config/ConfigShows.vue— updatescriptModessource touseShowStore()composables/useWebSocket.ts— fill inGET_CAST_LIST,ELECTED_LEADER,NO_LEADER,SCRIPT_SCROLLWS action handlersAll child routes under
/show-configremain asPlaceholderView— individual config sections are implemented in Phases 7–11.Test plan
npm run build— no errorsnpm run typecheck— passesnpm run ci-lint— passes/ui-new/show-configas admin with a show loaded → sticky sidebar renders with 10 buttons; active route highlighted; content area shows PlaceholderView/with toasttopvalue updates correctly🤖 Generated with Claude Code