Conversation
* Add tagged stage directions (issue #660) Stage directions can now be optionally tagged to a character or character group. When tagged, a character heading appears above the stage direction in config and live views (both full and compact layouts), matching the heading behaviour of dialogue lines. Backend: StageDirectionValidator relaxed from rejecting any character/group assignment to allowing one-or-neither (mutual exclusion only), mirroring the DialogueValidator pattern. Tests updated and extended. Frontend: ScriptLinePart shows character/group dropdowns for stage directions; the SD style selector moves onto the same row. Navigation mixin skips only untagged stage directions when looking back for heading context. Both ScriptLineViewer components (config + live) render the character heading with a 1rem bottom gap before the stage direction text. ScriptLineViewerCompact displays the character name in the left column for tagged stage directions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Reduce template duplication in tagged stage direction viewers Extract taggedStageDirectionHeadingName computed to both ScriptLineViewer components, replacing the repeated character/group v-if/v-else name lookup block with a single interpolation. Extract characterOrGroupName() method to ScriptLineViewerCompact to unify the same lookup used in the dialogue and stage direction character columns. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Move isTaggedStageDirection/taggedStageDirectionHeadingName/characterOrGroupName to scriptDisplayMixin Eliminates cross-file duplication flagged by SonarQube by centralising the three shared computed properties and method in the mixin, which is already imported by all three viewer components. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
- Bump typescript from ~5.4.5 to ^6.0.0 - Bump @typescript-eslint/eslint-plugin and /parser from ~7.18.0 to ^8.0.0 - Add typescript-eslint ^8.0.0 meta-package (required for v8 flat config API) - Remove deprecated baseUrl from tsconfig.json; update paths to ./src/* - Update eslint.config.ts to use v8 flat config rules pattern - Disable no-unsafe-function-type (v8 successor to ban-types for Vue 2 Function props) - Fix prefer-const in logger.ts; remove stale eslint-disable in vue-shims.d.ts Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* Migrate electron frontend from JavaScript to TypeScript (#1032) Converts all 5 source files to TypeScript using the same conventions as the recent client migration: strict null checks, NodeNext modules, and @typescript-eslint v8. Adds a tsc compilation step (output to dist/) since the Electron main process needs real .js files unlike the Vite-built client. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix package-lock.json out of sync after npm install Regenerated lockfile from scratch to include transitive deps (encoding, iconv-lite) introduced by the TypeScript devDependencies. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
documentation
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 9750f23. ♻️ This comment has been updated with latest results. |
Python Test Results 1 files 1 suites 1m 21s ⏱️ Results for commit 9750f23. ♻️ This comment has been updated with latest results. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.