Fix V3 config backups tab errors#1079
Merged
Merged
Conversation
- Add `case 'NOOP': break;` to the WebSocket handleMessage switch so the intentional NOOP carrier OP (used to deliver ACTION-based messages on connect) is silently consumed instead of falling to the default warn log. - Remove invalid BVN 0.45.x props `sort-by="created_at"` and `:sort-desc="true"` from ConfigBackups BTable. BVN replaced the old BV2 string/bool pair with `v-model:sort-by` (BTableSortBy[]); passing a string caused computedItems to call `"created_at"?.filter(fn)` which threw TypeError. Backend already returns backups sorted newest-first. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
case 'NOOP': break;to thehandleMessageswitch inuseWebSocket.ts. The backend intentionally sends{"OP": "NOOP", "ACTION": "GET_SETTINGS"}on every WS connection — NOOP is a carrier OP for ACTION-based messages — but the switch had no handler for it, causing a spurious "Unknown OP received from WebSocket: NOOP" warning on every connect.sort-by="created_at"and:sort-desc="true"fromConfigBackups.vue. BVN replaced the old Bootstrap Vue 2 string/bool sort pair with a unifiedv-model:sort-byacceptingBTableSortBy[]. Passing a static string caused BVN's internalcomputedItemsto call"created_at"?.filter(fn), which threwTypeError: o.value?.filter is not a function. The backend already returns backups sorted newest-first, so no client-side initial sort is needed. Column-header sorting still works via thesortable: truefield config.Test plan
/config→ Backups tab🤖 Generated with Claude Code