Conversation
* Add front end button and back end route for show deletion
* Fix show deletion: cascade sessions, circular FKs, load param parsing, and loading state
- Fix `bool("false") == True` bug: show creation loaded the show regardless of
the `load` query param; replace with `.lower() == "true"` string comparison
- Add `Show.show_sessions` cascade relationship and null `current_session_id`
before deletion to handle ShowSession → ScriptRevision FK blocking cascade
- Add `post_update=True` to `Show.first_act`, `Act.first_scene`,
`Act.previous_act`, and `Scene.previous_scene` to resolve
CircularDependencyError when deleting shows with multiple acts/scenes
- Expand `test_delete_show_with_full_data` to cover multiple acts/scenes with
linked-list pointers and a past ShowSession — the cases that only surface
with real show data
- Add `isDeleting`/`deletingId` loading state to ConfigShows in both Vue 3
and Vue 2 frontends, disabling all delete buttons during a request
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Apply ruff and Prettier formatting fixes
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace native HTML title attributes with v-b-tooltip directive throughout client-v3 to restore Bootstrap-styled tooltips. Replace the plain "?" text span in ConfigSettings with IMdiHelpCircle icon, and restore the missing help icon on the Browser Console Log Level setting in UserSettingsConfig. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
client
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 049d852. ♻️ This comment has been updated with latest results. |
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 049d852. ♻️ This comment has been updated with latest results. |
Python Test Results 1 files 1 suites 1m 36s ⏱️ Results for commit 049d852. ♻️ This comment has been updated with latest results. |
Playwright E2E Results (firefox)151 tests 151 ✅ 1m 33s ⏱️ Results for commit 049d852. ♻️ This comment has been updated with latest results. |
Playwright E2E Results (chromium)151 tests 151 ✅ 1m 31s ⏱️ Results for commit 049d852. ♻️ This comment has been updated with latest results. |
BVN's v-b-tooltip directive teleports a persistent DOM node to <body> for every bound element, causing quadratic growth in ResourceAvailability (scenes × mics) and linear growth in SceneDensityHeatmap and MicAllocations. The leaked nodes also polluted Playwright text locators (broke spec 03). Replace per-cell v-b-tooltip with a single useHoverTooltip composable that drives one shared Teleport overlay using Bootstrap's existing .tooltip CSS classes, so the appearance is identical with zero persistent nodes at rest. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit 6bf308c.
* Revert "Fix v-b-tooltip DOM node leak in grid/list components (#1093)" This reverts commit 6bf308c. * Fix v-b-tooltip DOM node leak in grid/list components (#1093) BVN's v-b-tooltip directive teleports a persistent DOM node to <body> for every bound element, causing quadratic growth in ResourceAvailability (scenes × mics) and linear growth in SceneDensityHeatmap and MicAllocations. Replace per-cell v-b-tooltip with a single shared BTooltip component per parent driven by @mouseenter/@Mouseleave — one DOM node regardless of row count, identical appearance and positioning via BVN's own floating-ui logic. A useHoverTooltip composable manages the shared target/text/visible state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix missing useHoverTooltip imports in mics components The composable was called in script setup but never imported, causing ReferenceError at runtime. Added explicit import to all three components. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Replace v-b-tooltip with mouseenter/mouseleave in all three mics components The merge conflict resolution had kept the old v-b-tooltip directive in the templates while only adding the useHoverTooltip script bindings. BVN's v-b-tooltip renders an inline node per bound element which, inside a CSS grid, occupies a grid cell and produces the staggered empty-column layout. Replaced all three remaining v-b-tooltip usages with the @mouseenter/@Mouseleave pattern that drives the shared BTooltip instance. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.