Fix stage direction override button always disabled#1271
Merged
Conversation
…e key
The frontend read `.stage_direction_styles` from the GET response but the
backend returns `{ "styles": [...] }`. The `?? []` fallback silently swallowed
`undefined`, leaving `stageDirectionStyles` empty and permanently disabling the
"New Override" button.
Also adds E2E coverage for the full override creation flow in spec 14, and
fixes a pre-existing strict-mode violation in the "About" tab test. "New
Override" button locators are scoped to `#stage-directions-table thead` to
avoid colliding with the same-named button in the Cue Colour Preferences tab
(BVN BTabs without `lazy` keeps all tab panels in the DOM).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 33ee933. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 33ee933. |
|
Python Test Results 1 files 1 suites 2m 6s ⏱️ Results for commit 33ee933. |
Playwright E2E Results (chromium)210 tests 210 ✅ 2m 15s ⏱️ Results for commit 33ee933. |
Playwright E2E Results (firefox)210 tests 210 ✅ 2m 10s ⏱️ Results for commit 33ee933. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StageDirectionStyles.vueread.stage_direction_stylesfrom the API response, but the backend returns{ "styles": [...] }. The?? []fallback silently swallowedundefined, keepingstageDirectionStylesempty and permanently disabling the "New Override" button via:disabled="overrideChoices.length <= 1".StageDirectionStyles.vue(onMountedfetch handler).14-user-settings.spec.tscovering the full override creation and deletion flow.#stage-directions-table theadto avoid colliding with the same-named button in the Cue Colour Preferences tab (BVN mounts all tab panels withoutlazy).Test plan
npm run ci-lint)🤖 Generated with Claude Code