Standardize on from __future__ import annotations and unquote type annotations
#882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annotations Add PEP 563 deferred annotation evaluation to all files that use TYPE_CHECKING or string-quoted forward references, then remove the now-unnecessary string quotes from Mapped[] type annotations and function parameter/return type annotations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
server
Client Test Results83 tests 83 ✅ 0s ⏱️ Results for commit ddfe09c. |
|
Python Test Results 1 files 1 suites 38s ⏱️ Results for commit ddfe09c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
from __future__ import annotations(PEP 563) to all 10 server-side files that useTYPE_CHECKINGor string-quoted forward referencesMapped[...]type annotations, function parameter annotations, and return type annotationsruff formatreformatting where line lengths changed (show.py)Test plan
ruff check server/passes with no errorsruff format server/reports no changes neededpytest— all 313 tests pass🤖 Generated with Claude Code