Fix stage direction style DELETE (reads ID from query param, not body)#993
Merged
Conversation
…of body
The delete handler was calling escape.json_decode(self.request.body) but
DELETE requests carry no body — the frontend sends the ID as a query
parameter (?id=N), matching all other DELETE endpoints in the codebase.
Replaces body decode with self.get_argument("id", None) + int validation
and adds four tests covering happy path, missing ID, invalid ID, and 404.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
small-diff
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete()handler inStageDirectionStylesControllerwas callingescape.json_decode(self.request.body)to read the style ID, but DELETE requests carry no body?id=N), matching every other DELETE endpoint in the codebase (characters, cast, cues, etc.)self.get_argument("id", None)+int()validation, and addsERROR_INVALID_IDto importsTest plan
test_delete_stage_direction_style— happy path: 200, style removed from DBtest_delete_stage_direction_style_missing_id— noidparam → 400test_delete_stage_direction_style_invalid_id—id=abc→ 400test_delete_stage_direction_style_not_found— unknown ID → 404ruff check: no issues🤖 Generated with Claude Code