Skip to content

[mediator/unity/client] add new test#62

Open
Egliss wants to merge 6 commits into
masterfrom
feature/unity_testcase
Open

[mediator/unity/client] add new test#62
Egliss wants to merge 6 commits into
masterfrom
feature/unity_testcase

Conversation

@Egliss
Copy link
Copy Markdown
Contributor

@Egliss Egliss commented Jul 3, 2019

The PR dependency to #61

Summary

the PR add the Unity Project used by #61 's test and fix tiny bug.

  • Update UnityProject
    • Update Unity ver v2018.3.0b12-> v2018.4.3f1 (LTS)
    • Add DefaultAssetExporter processable asset
      • new scene +1
      • new model +2
    • Add some directory
  • Update sgmed.config will call new scene
  • Fix exporter's lacked asset check

#61 does not commiting in the PR

Review files

  • packages/scene-graph-unity/client/src/exporter/scene/DefaultSceneExporter.ts
  • packages/scene-graph-unity/client/example/sgmed.config.js

Check

TODO

  • Update README.md

return;
}

if (assets.length === 0) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes assets count is zero.

@Egliss Egliss changed the title [WIP] [mediator/client:Unity] add new test [WIP] [mediator/unity/client] add new test Jul 3, 2019
@Egliss Egliss changed the title [WIP] [mediator/unity/client] add new test [mediator/unity/client] add new test Jul 3, 2019
@Egliss Egliss requested review from dolow and zprodev July 4, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant