Skip to content

feat: add dremio space commands and reject single-component paths in folder create#24

Open
sandhyasun wants to merge 7 commits into
dremio:mainfrom
sandhyasun:fix/issue-13-space-commands
Open

feat: add dremio space commands and reject single-component paths in folder create#24
sandhyasun wants to merge 7 commits into
dremio:mainfrom
sandhyasun:fix/issue-13-space-commands

Conversation

@sandhyasun
Copy link
Copy Markdown

@sandhyasun sandhyasun commented May 13, 2026 •
edited
Loading

Summary

Fixes #13

Adds a dedicated `dremio space` command group (list / get / create / delete) and clarifies top-level vs nested catalog semantics in `dremio folder`.

New `dremio space` commands

  • `create` — runs `CREATE SPACE` SQL. On pre-Space-Plugin clusters that reject it with the legacy sentinel ("Legacy spaces are not supported"), falls back to `CREATE FOLDER` with a single-component path. All other failures propagate directly; "already exists" is rewritten from the internal `Folder [[source, name]]` form to `Space [name] already exists`.
  • `get` / `delete` — reject multi-component paths with a redirect to `dremio folder`.
  • `delete` — resolves the entity first and enforces `containerType == SPACE` to prevent accidentally deleting sources or other top-level catalog entities.

`dremio folder` behavior changes

  • `create ` — prints a deprecation warning and runs `CREATE FOLDER`. On pre-SP clusters this still succeeds (server allows it). On SP-enabled clusters the server rejects it — matching Dremio SQL and v0 REST semantics, so CLI behavior is consistent with those surfaces.
  • `get ` / `delete ` — now reject top-level paths and redirect to `dremio space get` / `dremio space delete`.
  • `create` — propagates SQL job failures as `Error:` instead of printing the raw FAILED JSON.

Net effect

Cluster type `space create` `folder create` (single) nested folders
pre-SP CREATE SPACE → fallback to CREATE FOLDER warning + succeeds unchanged
SP-enabled CREATE SPACE (direct) warning + server error unchanged
  • pre-SP clusters keep working with no change in behavior.
  • SP-enabled clusters enforce `dremio space` for top-level objects, consistent with SQL/REST.
  • All nested folder operations are unchanged on both cluster types.

Test plan

  • Unit tests: all 182 pass (space + folder command coverage)
  • Pre-SP cluster (3165): space create/list/get/delete, fallback, error messages, folder guards
  • SP-enabled cluster (3164): `CREATE SPACE` succeeds directly, `folder create` single-component fails server-side as expected

@sandhyasun @claude
feat: add dremio space commands and reject single-component paths i…
d2f3f18 
…n `folder create`

Spaces and folders are distinct catalog concepts but the CLI blurred
them: `dremio folder create "foo"` silently rewrote to CREATE SPACE,
which breaks on projects without Space Plugin and hides the semantic
difference.

Changes:
- `dremio folder create` now rejects single-component paths with a
  clear error pointing users to `dremio space create <name>` instead.
- New `dremio space` command group with `list`, `get`, `create`, and
  `delete` subcommands. `space list` filters the catalog to SPACE
  entities; the others delegate to the existing folder helpers.

Closes dremio#13

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 13, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2f3f18572

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/drs/commands/space.py
Comment thread src/drs/commands/space.py Outdated
sandhyasun and others added 4 commits May 13, 2026 16:47
@sandhyasun @claude
style: apply ruff formatting to space.py
3901116 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sandhyasun @claude
fix: fall back to CREATE FOLDER on pre-Space-Plugin clusters
e5d44eb 
On DCS clusters without Space Plugin enabled,
DCSCoordinatorCatalogServiceImpl.createSpace() rejects CREATE SPACE SQL
with "Legacy spaces are not supported." In that case, fall back to
CREATE FOLDER with a single-component path, which works on those clusters
because the single-component validation was added alongside Space Plugin.

All other failures (entity already exists, permissions, etc.) are
propagated immediately without triggering the fallback.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sandhyasun @claude
fix: tighten space/folder boundary guards and error propagation
149e47d 
- folder get/delete reject single-component paths (redirect to space get/delete)
- space get/delete reject multi-component paths (redirect to folder get/delete)
- create_folder propagates SQL job failures as DremioAPIError
- create_space fallback (pre-SP clusters): check fallback result and raise on
  failure; rewrite opaque "Folder [[source, name]] already exists" to
  "Space [name] already exists"

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sandhyasun @claude
fix: verify containerType == SPACE before delete_space
cc8f927 
Prevents dremio space delete from deleting non-space entities (sources,
home folders) that happen to share a single-component name.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sandhyasun
Copy link
Copy Markdown
Author

sandhyasun commented May 14, 2026 •
edited
Loading

Still in Draft . Need to look into maintaining compatibility pre/post Space Plugin once more.

@sandhyasun @claude
fix: align folder/space command contracts and expand introspect schema
48fe2df 
- folder create: replace ValueError with deprecation warning + server-driven
  behavior (pre-SP succeeds, SP fails); update help text to match
- folder get/delete: keep single-component redirect; update help text
- folder group: update module docstring and app help to reflect dual purpose
  (nested folders + top-level catalog listing)
- output.py: add warn() for stderr deprecation warnings
- introspect.py: add space.list/get/create/delete entries; fix stale
  folder.create description and sql_template
- tests: add deprecation warning, pre-SP success, and SP failure tests for
  folder create single-component path

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 15, 2026
Closed
Open
@sandhyasun @claude
docs: update README for dremio space command group
00764c9 
- Add dremio space to command summary table
- Split CRUD table: Spaces row -> space.*, Folders row -> nested-only
- Fix folder create description: uses CREATE FOLDER; single-component paths
  deprecated and may fail on Space-Plugin-enabled clusters
- Add space.py to file tree

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 15, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add 'dremio space' commands and reject single-component paths in 'folder create'

2 participants

@sandhyasun @CLAassistant