Skip to content

Fixed broken filter logic added tasksubmissioncounts#517

Merged
lucaro merged 1 commit into
dres-dev:devfrom
Jackzzey:pr/442
May 21, 2026
Merged

Fixed broken filter logic added tasksubmissioncounts#517
lucaro merged 1 commit into
dres-dev:devfrom
Jackzzey:pr/442

Conversation

@Jackzzey
Copy link
Copy Markdown

  1. submissions-of.pipe.ts — Fixed the broken filter logic. The old filter used
    submissionInfos[idx] (stream index as array index) to check evaluationId, which always filtered out the result when the array was empty.
    Replaced the whole filter+flatMap chain with a simple map(infos => infos.flatMap(i =>
    i.submissions)).
  2. run-async-admin-view.component.ts — Added taskSubmissionCounts: Observable<Map<string, number>>. It's driven by merge(timer(0, 15000), this.update) so it refreshes every 15 seconds and immediately whenever the refresh/start/terminate action fires. It fetches all template counts in parallel via forkJoin, builds a Map<templateId, count>, and shares the result.
  3. run-async-admin-view.component.html — Both submission count cells now use
    (taskSubmissionCounts |
    async)?.get(task.templateId) (Tasks Overview) and (taskSubmissionCounts | async)?.get(task.id) (Tasks per Team), replacing the stale pure-pipe calls. Also fixed the typo "Submisssions" → "Submissions".

@lucaro lucaro merged commit ba0a7f7 into dres-dev:dev May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants