[#952] Updated Lagoon deployment script to use variable update.

[richardgaunt]

closes #952

Checklist before requesting a review

• I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
• I have added a link to the issue tracker
• I have provided information in Changed section about WHY something was done if this was not a normal implementation
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• I have run new and existing relevant tests locally with my changes, and they passed
• I have provided screenshots, where applicable

Changed

1. Updated to lagoon update variable rather than add and delete.
2. Updated tests.

Screenshots

[richardgaunt]

Had trouble running locally - with the deployment code we could test it in isolation as unit tests rather than deploying actual builds.

[AlexSkrypnyk]

@richardgaunt the numbers (3, 4 etc.) at the end of the assertions need to be updated throughout the whole test after the order being modified (this is due to using an old way of asserting that commands run in the order)

assert_contains "-l testlagoon update variable -p testproject -e testbranch -N DREVOPS_PROVISION_OVERRIDE_DB -V 0 -S global" "$(mock_get_call_args "${mock_lagoon}" 3)"

[AlexSkrypnyk]

@richardgaunt
could you please confirm that you have tested this code for 2 cases on real Lagoon instance:

1. The env is brand new
2. The env already exists and the deployment is a follow-up deployment

This is to make sure that Lagoon's API supports running update on non-existing variable.

[AlexSkrypnyk]

@richardgaunt
Could you please update tests. Thank you

[richardgaunt]

@richardgaunt could you please confirm that you have tested this code for 2 cases on real Lagoon instance:

1. The env is brand new

2. The env already exists and the deployment is a follow-up deployment

This is to make sure that Lagoon's API supports running update on non-existing variable.

Tested with the PR new environment creation, tested with overriding a database. All worked correctly and the variables were correct values after deploying.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.51%. Comparing base (e5808aa) to head (cda0d0f).

Files	Patch %	Lines
scripts/drevops/deploy-lagoon.sh	50.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #1209       +/-   ##
============================================
- Coverage    71.88%   61.51%   -10.37%     
============================================
  Files           38       38               
  Lines         2849     2843        -6     
============================================
- Hits          2048     1749      -299     
- Misses         801     1094      +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.