-
-
Notifications
You must be signed in to change notification settings - Fork 28
Updated CI Runner to 25.5.0. #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
""" WalkthroughThe Docker image used for CI/CD jobs across CircleCI and GitHub Actions workflows was updated from version Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to updating container image tags and do not affect control flow or feature logic. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
.circleci/config.yml(1 hunks).github/workflows/build-test-deploy.yml(3 hunks).github/workflows/vortex-test-common.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: build (1)
- GitHub Check: build (0)
- GitHub Check: vortex-test-workflow (3)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-workflow (1)
- GitHub Check: vortex-test-deployment (1)
- GitHub Check: vortex-test-workflow (0)
- GitHub Check: vortex-test-deployment (0)
- GitHub Check: vortex-test-common
- GitHub Check: vortex-test-installer (8.4)
- GitHub Check: vortex-test-installer (8.3)
- GitHub Check: vortex-test-installer (8.2)
- GitHub Check: vortex-test-docs
|
|
||
| container: | ||
| image: drevops/ci-runner:25.3.0 | ||
| image: drevops/ci-runner:canary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Pin runner image to explicit version for reproducibility
Using the canary tag can lead to non-deterministic CI runs. Since the PR aims to update to version 25.5.0, explicitly specify drevops/ci-runner:25.5.0.
- image: drevops/ci-runner:canary
+ image: drevops/ci-runner:25.5.0Also applies to: 168-168, 366-366
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1629 +/- ##
========================================
Coverage 71.56% 71.56%
========================================
Files 76 76
Lines 4308 4308
========================================
Hits 3083 3083
Misses 1225 1225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f56a592 to
989ddae
Compare
Summary by CodeRabbit